Skip to content

Improve the time series api + add policy for regression #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 16, 2025
Merged

Improve the time series api + add policy for regression #7156

merged 17 commits into from
Sep 16, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Sep 12, 2025 •
edited
Loading

For API:

  • Add model filters during query
  • Add format options table, and raw
  • add API hook method for frontend

add listCommits api

For regression lambda

  • Add regression policy for compilation latency (if new value> 1.05 x baseline, consider as regression)
  • Change the data format to match with the api

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Sep 16, 2025 9:10am

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@yangw-dev yangw-dev changed the title add old way replace existing api Sep 12, 2025
@yangw-dev yangw-dev changed the title replace existing api Improve the time series api Sep 13, 2025
@yangw-dev yangw-dev requested a review from huydhn September 13, 2025 18:36
@yangw-dev yangw-dev changed the title Improve the time series api Improve the time series api + add policy for regression Sep 13, 2025
@yangw-dev yangw-dev marked this pull request as ready for review September 13, 2025 19:30
huydhn
huydhn reviewed Sep 15, 2025
View reviewed changes
torchci/clickhouse_queries/compilers_benchmark_api_commit_query/query.sql Outdated
multiSearchAnyCaseInsensitive(arch, {arch: Array(String)})
OR empty({arch: Array(String)})
)
ORDER BY branch, timestamp, commit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order by commit is weird, as it's just a random hash. Do you mean sorted by workfflow_id here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this, think timstamp is enough

huydhn
huydhn approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed mainly the SQL queries and found a minor issue there. The rest LGTM I guess

@yangw-dev yangw-dev merged commit 9ae4838 into main Sep 16, 2025
7 checks passed
@yangw-dev yangw-dev deleted the replaceapi branch September 16, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangw-dev @huydhn