Skip to content

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Sep 14, 2025

Overview

Build dynamic rendering with compiler regression page

set up benchmark compiler page to render dynamically based on the request, most of the component will be reused as we migrate our ui to dynamic rendering.

Data management

use zustand as context provider to track global data state within the page.

Customized support

Currently we support customized data bridges, the main way to adjust customized fields and metrics

  1. initial queryParams
  2. queryParamsConverter
  3. dataRenderSection for timeserids display and dropdownList in side bar

Sticky Search Side Bar with dynamic changes

Set up a sticky search side bar that only applies changes if timerange, metrics and branches are changed.

Logics:

The branch list is dynamically rendered when timeRange or metric filters are changed.
the apply will disable if user changes the timerange and metrics, but no branch data exist

Why do this way

Benchmark data fetching can be expensive (> 6 ~ 10 secs),it should only apply changes when user tuned the query params in an ideal stage

Demo

https://torchci-git-newcompileruiclean-fbopensource.vercel.app/benchmark/compilers_regression

image

Nexstep

  • Add hyperlink to the page
  • Dynamically Render compiler time series charts and comparison table

Copy link

vercel bot commented Sep 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Sep 16, 2025 10:56am

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2025
@yangw-dev yangw-dev changed the base branch from main to replaceapi September 14, 2025 05:51
@yangw-dev yangw-dev changed the title New compiler UI clean Build dynamic rendering with compiler regression page Sep 14, 2025
@yangw-dev yangw-dev marked this pull request as ready for review September 14, 2025 07:03
@yangw-dev
Copy link
Contributor Author

I'm trying to see if i can make the compiler page also be part of the general regression ui.

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped to unblock

Base automatically changed from replaceapi to main September 16, 2025 09:28
@yangw-dev yangw-dev merged commit c5db0d8 into main Sep 16, 2025
5 checks passed
@yangw-dev yangw-dev deleted the new_compiler_ui_clean branch September 16, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants