Run DSv3 on 1D AP w/ WIP local_map #1700
Draft
+202
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 1D AP work on DSv3.
requires stack on pytorch/pytorch#162702 and AP main
doesn't yet contain all the fixes to local_map, but putting up the PR since the current branch doesn't run, and this at least runs (just inefficient because of EP's inputs/outputs being force replicated).
1D AP logs: https://gist.github.com/xmfan/51402bd27716303b76e6ebd022f92036
non-AP still runs: https://gist.github.com/xmfan/82c8e988fba26fe5322fdc9be74c9c64