port true bf16 training into forge experiment #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebsmothers
requested review from
allenwang28,
joecummings,
pbontrager,
tianyu-l and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
joecummings
approved these changes
Sep 30, 2025
tianyu-l
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I went out on leave after opening #1646 so never actually finished it out to enable bf16 training in the forge experiment, which is what we ultimately wanted (thanks to @joecummings and @tianyu-l for pushing it through).
I also see there was some discussion on the original PR which I belatedly responded to. If there are still concerns there let me know. Otherwise if we are not gonna revert that PR we should at least that one so that forge can reap the benefits as intended.