Workaround AC HOP mutation issue when tracing token dispatch #1984
+37
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #1984, branch: xmfan/stack/2
meta-cla
bot
added
the
CLA Signed
xmfan
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
tianyu-l
requested changes
Nov 5, 2025
Comment on lines
+146
to
+149
| input_shape, | ||
| permuted_indices, | ||
| input_splits, | ||
| output_splits, |
There was a problem hiding this comment.
These shouldn't be exposed to single-device model code. Plus, I don't think it will work if EP is not used.
If it's getting too hard, maybe we should use local_map / to_local to re-implement MoE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #1935
Stacked PRs:
tlparse: https://fburl.com/sqxd6c0w
Workaround AC HOP mutation issue when tracing token dispatch
TORCH_COMPILE_FORCE_DISABLE_CACHES=1 HF_TOKEN=<token> HF_HUB_DISABLE_XET=1 CONFIG_FILE="./torchtitan/models/deepseek_v3/train_configs/deepseek_v3_16b.toml" with-proxy ./run_train.sh --model.name simple_fsdp.deepseek_v3This is a problem for SimpleFSDP where we want to fullgraph the entire model, these "mutation" cause graph break
It is less of a problem outside SimpleFSDP, because we don't currently compile token dispatch