[compiler toolkit] compiler toolkit without TP #1996
+24
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we hardcode "tp" dimension when parallelizing inputs (converting from plain tensor to DTensor). This won't work when there is no TP is our parallelisms (e.g., SimpleFSDP only or SimpleFSDP + EP)
The fundamental reason is that currently SimpleFSDP only accepts plain tensor inputs. Making it accept DTensor inputs would require eager rewrite of SimpleFSDP's frontend.
So as a workaround, we only DTensorize the inputs when there is a "tp" dimension in the world_mesh.
SimpleFSDP Only on llama3
SimpleFSDP + EP on dsv3