Skip to content

Fix Parametrizations tutorial #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: RC-TEST-2.8
Choose a base branch
from
Draft

Fix Parametrizations tutorial #3461

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1238f0
Fix Parametrizations tutorial
svekars Jul 14, 2025
76261dc
Update parametrizations.py
svekars Jul 14, 2025
95aaf0b
Update intermediate_source/parametrizations.py
svekars Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion intermediate_source/parametrizations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def forward(self, X):
# Inspecting a parametrized module
# --------------------------------
#
# When a module is parametrized, we find that the module has changed in three ways:
# When a module is parametrized, we find that the module has changed in the following ways:
#
# 1) ``model.weight`` is now a property
#
Expand Down Expand Up @@ -307,6 +307,8 @@ def right_inverse(self, A):
# Assume A orthogonal
# See https://en.wikipedia.org/wiki/Cayley_transform#Matrix_map
# (A - I)(A + I)^{-1}
eps = 1e-6 # Add small regularization to avoid singularity
reg_term = eps * self.Id
return torch.linalg.solve(A + self.Id, self.Id - A)

layer_orthogonal = nn.Linear(3, 3)
Expand Down
Loading