Merged the IR and Vis uncertainty changes #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule which merges the two uncertainty outputs into a single xarray output.
Fixed issue causing NaNs in uncertainty output
…ible # Conflicts: # pygac/calibration/vis_uncertainty.py # pygac/klm_reader.py # pygac/pod_reader.py # pygac/reader.py # pygac/utils.py
Fixed issue of NaNs appearing in uncertainty output
…er than
calibrated values ("counts" rather than "channels")
…tions (before/after solZA max)
…ratio out of limits
…anck function variations but adding 0.5K@300K in radiance space for this component
…uses radiance at 300K assuming uncertainty of 0.5K) and updates to data files with new solar contamination routine.
write_solar option to output data to be used in unit testing
1) Added test for updated PRT numbering module 2) Added test for aspects of the IR uncertainty module including solar contamination of the gain, calculation of the min PRT standard deviation gain and calculation of the ICT uncertainty. Uses data from an orbit of real AVHRR data stored in associated CSV file.
|
@jmittaz looks like matplotlib is still imported somewhere where the tests are running, since the run crashes. |
… actual TLE data, unit tests in test_klm.py now passing
addition of get_angles in create_counts_data in reader.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 77.35% 71.20% -6.16%
==========================================
Files 31 36 +5
Lines 3317 5226 +1909
==========================================
+ Hits 2566 3721 +1155
- Misses 751 1505 +754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
micron data) Vis calibration (accessing 1.6 micron channel) and output uncertainty (flag changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into code including a new module
which merges the two uncertainty outputs into a single xarray output.