add rocket chat client and allure testops integration #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add client for rocket chat
# Conflicts: # README.md
Rocket chat client
|
@svasenkov можете плиз проревьюить и смержить, нужная фича |
valfirst
requested changes
Jul 14, 2023
Comment on lines
+30
to
+31
| implementation('io.rest-assured:rest-assured:4.4.0') | ||
| implementation('org.jboss.resteasy:resteasy-jackson2-provider:3.0.6.Final') |
There was a problem hiding this comment.
are these dependencies used somewhere?
| } | ||
| catch (JsonSyntaxException e) { | ||
| JsonReader reader = new JsonReader(new StringReader(json)); | ||
| reader.setLenient(true); |
There was a problem hiding this comment.
why is this tweak needed?
| @@ -19,14 +21,23 @@ | |||
| public class Chart { | |||
|
|
|||
| public static byte[] createChart(Base base) throws MessageBuildException { | |||
| return createChart(base, null); | |||
| } | |||
| public static byte[] createChart(Base base, TestOps testOps) throws MessageBuildException { | |||
There was a problem hiding this comment.
the thing here is generic Chart starts "knowing" about TestOps, which is not good if low coupling is followed
theshadowco
reviewed
Sep 28, 2023
| - [x] [Email config](https://github.com/qa-guru/allure-notifications/wiki/Email-configuration) | ||
| - [x] [Skype config](https://github.com/qa-guru/allure-notifications/wiki/Skype-configuration) | ||
| - [x] [Mattermost config](https://github.com/qa-guru/allure-notifications/wiki/Mattermost-configuration) | ||
| - [x] [Rocket config] |
| @@ -117,6 +155,11 @@ Languages: 🇬🇧 🇫🇷 🇷🇺 🇺🇦 🇧🇾 🇨🇳 | |||
| } | |||
| } | |||
| ``` | |||
| You only need: | |||
| - to fill needed options in `base` block (please, be careful, `language` field is required!); | |||
| - to configure desired destinations for notifications (`telegram`, `slack`, `mattermost`, `skype`, `mail`), keep in mind it's possible to set multiple destinations at once, if no destination is set, then no notification will be sent and no error will occur; | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.