plot saving to be specified in config.user #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB keys in config are now "save_pdf" and "save_png". |
…d in less good place
… and allow other kwargs
|
I've updated this and tested it so that it definitely works but I realise it conflicts with #166. Since this version is really not a big change I'd be happy for that pr to get merged first and then I update this one but I'd really like it to be soon (like in the next week kind of soon) or to get this one merged instead @ThorvaldLarsen @jenshnielsen thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using doNd if the 'do_plots' keyword argument is True plots will be generated which are saved in both png and pdf format. This pull request makes the saving configurable via the config file so that you can choose if you want any generated plots to be saved as png, pdf, both or neither :)
TODO:
@jenshnielsen