Add support for ArrayParameter in DoNds #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have looked at the test and realized, that it is not actually necessary. Maybe it was when the changes first were made. |
|
The multiparameter part is afaik still not handled within qcodes |
|
True, but this we should handle in qcodes. |
|
Not sure about the sleep. Also this PR is quite old so seems very plausible that what it solved has since been fixed in qcodes. |
|
Well not this PR, but the original one I made to handle array paramters with new dataset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #166
see diff here:
80516e7...ThorvaldLarsen:doNd_save_image