Skip to content

Conversation

@VinzentRisch
Copy link
Contributor

closes #372

  • adds new collation actions for GenomeData[Genes] and GenomeData[Proteins]
  • refactors code for collation actions for loci and ortholog annotations with one helper function

@VinzentRisch
Copy link
Contributor Author

Hey @misialq
Do you agree with these changes? I created a helper function that handles all collations of loci, proteins, genes and ortholog annotations.
Before the collation of loci only handled artifacts that were not per sample. The new one can also handle per sample data.
I also removed the check for if the file already exists with the warning, because this is not done somewhere else. Or do you think this is something that would be beneficial?

@lizgehret lizgehret requested a review from misialq September 18, 2025 17:21
@lizgehret lizgehret moved this from Backlog to Needs Review in 2025.10 👻 Sep 18, 2025
@github-project-automation github-project-automation bot moved this to Backlog in 2025.10 👻 Sep 18, 2025
Copy link
Collaborator

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VinzentRisch, looks good altogether but please see some specific comments below.

@github-project-automation github-project-automation bot moved this from Needs Review to In Development in 2025.10 👻 Oct 2, 2025
@misialq
Copy link
Collaborator

misialq commented Oct 13, 2025

Hey @lizgehret, this looks good to go for me, unless you want to have a look!

Copy link
Collaborator

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-project-automation github-project-automation bot moved this from In Development to Ready for Merge in 2025.10 👻 Oct 13, 2025
@lizgehret lizgehret merged commit e29df78 into qiime2:dev Oct 15, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Merge to Changelog Needed in 2025.10 👻 Oct 15, 2025
@lizgehret lizgehret assigned lizgehret and unassigned misialq Oct 15, 2025
@lizgehret lizgehret moved this from Changelog Needed to Completed in 2025.10 👻 Oct 15, 2025
@lizgehret lizgehret removed their assignment Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

ENH: add collation functions for GenomeData[Genes] and GenomeData[Proteins]

3 participants