Skip to content

Conversation

lizgehret
Copy link
Member

No description provided.

@lizgehret lizgehret self-assigned this Sep 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in QIIME 2 - Triage 🚑 Sep 4, 2025
@github-project-automation github-project-automation bot moved this to Backlog in 2025.10 👻 Sep 4, 2025
@lizgehret lizgehret moved this from Backlog to In Development in 2025.10 👻 Sep 4, 2025
@lizgehret lizgehret assigned Oddant1 and unassigned lizgehret Sep 11, 2025
@lizgehret lizgehret moved this from In Development to Needs Review in 2025.10 👻 Sep 11, 2025
Copy link
Member

@Oddant1 Oddant1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment and one actual change I think. Most of the annotation commands don't have the ToolCommand class which leads to the following when invoking them on the cli

image

The top one does have the ToolCommand class and looks correct. The others do not.

@github-project-automation github-project-automation bot moved this from Needs Review to In Development in 2025.10 👻 Sep 15, 2025
@Oddant1 Oddant1 assigned lizgehret and unassigned Oddant1 Sep 15, 2025
@lizgehret
Copy link
Member Author

One comment and one actual change I think. Most of the annotation commands don't have the ToolCommand class which leads to the following when invoking them on the cli
image

The top one does have the ToolCommand class and looks correct. The others do not.

oh thanks @Oddant1 that was definitely an oversight on my end. this has been fixed and should be ready for review round 2!

@lizgehret lizgehret assigned Oddant1 and unassigned lizgehret Sep 18, 2025
@lizgehret lizgehret requested a review from Oddant1 September 18, 2025 21:46
@lizgehret lizgehret moved this from In Development to Needs Review in 2025.10 👻 Sep 18, 2025
@Oddant1
Copy link
Member

Oddant1 commented Sep 18, 2025

lgtm

@github-project-automation github-project-automation bot moved this from Needs Review to Ready for Merge in 2025.10 👻 Sep 18, 2025
@Oddant1 Oddant1 merged commit 3740acc into dev Sep 18, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Merge to Changelog Needed in 2025.10 👻 Sep 18, 2025
@Oddant1 Oddant1 removed their assignment Sep 19, 2025
@Oddant1 Oddant1 moved this from Changelog Needed to Completed in 2025.10 👻 Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants