Use marginal_distribution() instead of marginal_counts() (backport #1144) #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
### Summary This commit updates the Qiskit marginalization function used in qiskit-experiments. Qiskit has 2 different function available for marginalizing counts: `marginal_counts()` [1] which is designed to work with `Counts` or `Result` objects and does **not** respect ordering of the indices passed in. The other is `marginal_distribution()` [2] which is designed to work with `Counts`, `Probabilities`, `QuasiProbabilities`, or a dictionary with string keys and integer or float values that respects the order of the indices passed in (so it can be used to permute the bits). In general if you're not working with a `Result` object it is better to use `marginal_distribution()` because it is written primarily in Rust and 10-100x faster than `marginal_counts()`. ### Details and comments [1] https://qiskit.org/documentation/stubs/qiskit.result.marginal_counts.html [2] https://qiskit.org/documentation/stubs/qiskit.result.marginal_distribution.html (cherry picked from commit 10b6182)
coruscating
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1144 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com