-
Notifications
You must be signed in to change notification settings - Fork 131
Remove 0.5 deprecations #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 0.5 deprecations #1186
Conversation
deprecations
…riments into 0.5-deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @coruscating for housekeeping stuff. This makes codebase much cleaner :)
return _wrapper | ||
|
||
|
||
def cos( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this is not the scope of this PR, but we can deprecate this entire file. Note that fit functions are now provided by LMFIT string representation, and these functions are no longer used unless users use them on different purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Helena, this PR looks good to me. We can merge this PR with just one more nitpick.
"beta", | ||
new_alias="outcome_prior", | ||
since="0.5", | ||
additional_msg="Instead, use the ``outcome_prior`` argument.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message is automatically generated.
https://github.com/Qiskit/qiskit-terra/blob/364d6fdea34c7ec54e6f5d3581e8a0ec6c8bfb5d/qiskit/utils/deprecation.py#L151-L152
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, I've removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please merge once numpy errors are resolved.
Summary
This PR removes objects scheduled for removal after the 0.5 release and switches deprecation wrappers to the new Terra wrappers introduced in 0.24.
Details and comments
*args
and**kwargs
at present. This is being tracked in Better deprecation handling for dataclasses Qiskit/qiskit#10144.block_for_results()
have also switched toassertExperimentDone()
where possible.