Skip to content

completion_times property fix #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

completion_times property fix #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
703c7c9
completion_times property fix
gadial Oct 31, 2023
e299b1f
Release notes
gadial Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions qiskit_experiments/framework/experiment_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,10 @@ def completion_times(self) -> Dict[str, datetime]:
"""Returns the completion times of the jobs."""
job_times = {}
for job_id, job in self._jobs.items():
if job is not None and "COMPLETED" in job.time_per_step():
job_times[job_id] = job.time_per_step().get("COMPLETED")
if job is not None:
job_times[job_id] = job.time_per_step().get(
"COMPLETED", None
) or job.time_per_step().get("finished", None)

return job_times

Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/completion_times_fix-6f8d5449d0de4a9d.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
The :meth:`ExperimentData.completion_times` property was fixed to correctly
read the data from the `IBMCircuitJob` object.