Skip to content

Cleanup the guess algorithms for curve fitting #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cleanup the guess algorithms for curve fitting #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e10ab72
update standard analysis classes
nkanazawa1989 Aug 22, 2022
ab9ebff
Merge branch 'main' of github.com:Qiskit/qiskit-experiments into feat…
nkanazawa1989 Aug 22, 2022
917f4ba
Update experiment classes with one stop algorithm
nkanazawa1989 Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions qiskit_experiments/curve_analysis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,10 @@ def _create_analysis_results(self, fit_data, quality, **metadata):
guess.max_height
guess.min_height
guess.oscillation_exp_decay
guess.frequency_lorentz_fit
guess.low_frequency_limit
guess.sinusoidal_freq_offset
guess.composite_sinusoidal_estimate

Utilities
*********
Expand Down
1 change: 0 additions & 1 deletion qiskit_experiments/curve_analysis/curve_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ def _objective(_params):
max=bounds[1],
vary=name not in fixed_parameters,
)

try:
new = lmfit.minimize(
fcn=_objective,
Expand Down
Loading