-
Notifications
You must be signed in to change notification settings - Fork 1
[5539][IMP] inventory_reporting: add summary report #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review
Code review
I only noticed one thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yostashiro @kanda999
Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nobuQuartile Please update the translation.
_("Operation Type Total Value"), | ||
] | ||
for col, header in enumerate(headers): | ||
ws.write(0, col, header) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we adjust the column widths so the presentation is a bit nicer when the file is opened (we can do the same for other files as well, but not a must this time)?
d3b414f
to
7aaae3e
Compare
@nobuQuartile Please review my latest updates and update the translation as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Yoshi Tashiro (Quartile) <[email protected]>
Co-authored-by: Yoshi Tashiro (Quartile) <[email protected]>
5539