Skip to content

Conversation

AungKoKoLin1997
Copy link
Contributor

Copy link
Contributor

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review
Code review
I only noticed one thing.

Copy link
Contributor

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@yostashiro @kanda999
Please review.

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nobuQuartile Please update the translation.

_("Operation Type Total Value"),
]
for col, header in enumerate(headers):
ws.write(0, col, header)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we adjust the column widths so the presentation is a bit nicer when the file is opened (we can do the same for other files as well, but not a must this time)?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-imp-inventory_reporting_summary_report branch from d3b414f to 7aaae3e Compare August 7, 2025 01:48
@AungKoKoLin1997
Copy link
Contributor Author

@nobuQuartile Please review my latest updates and update the translation as well.

@nobuQuartile
Copy link
Contributor

I updated the ja.po and some column names.
The column names were difficult to understand, so I made them the same as the column names in the existing report.
image

Copy link
Contributor

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nobuQuartile and others added 2 commits August 12, 2025 12:37
Co-authored-by: Yoshi Tashiro (Quartile) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants