Only log manifests as applied if the process completes succesfully #49458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsSven
changed the title
gsmet
approved these changes
Aug 11, 2025
|
I will take the responsibility to merge this one :). Thanks, it was a good idea to isolate it! |
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was originally included as an extra fix in #49415, but since that PR has turned into an architecture discussion that may take some time (and likely won't be merged in its current state), I thought I'd extract this fix out into its own PR.
The log message would always state it applied a manifest, even if it ran into issues. This PR moves the log message such that it only states this if the manifest was applied succesfully. This prevents receiving messages such as: