-
Notifications
You must be signed in to change notification settings - Fork 3k
Introduce support for hibernate.type.preferred_*_jdbc_type properties
#50454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @gsmet (hibernate-orm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I added a few comments below.
extensions/hibernate-orm/deployment/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
...eployment/src/test/java/io/quarkus/hibernate/orm/config/properties/ConfigPropertiesTest.java
Show resolved
Hide resolved
|
@yrodiere thanks saw it, is still in draft so I will take them in account while i will be writing the remaining part! Thanks a lot 🙏🏻 |
|
@yrodiere First issue so i don't know if i missed something :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but the config group stuff and property naming is really off. See my comment in the conversation above for a suggestion on how to do it :)
hibernate.type.preferred_*_jdbc_type properties
0bacffd to
f36b2e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The properties shouldn't be in application.properties in this case (see below). And ideally it would be great to have an integration test, but I'll let you see if you have time for that :)
extensions/hibernate-orm/deployment/src/test/resources/application.properties
Outdated
Show resolved
Hide resolved
...eployment/src/test/java/io/quarkus/hibernate/orm/config/properties/ConfigPropertiesTest.java
Outdated
Show resolved
Hide resolved
...eployment/src/test/java/io/quarkus/hibernate/orm/config/properties/ConfigPropertiesTest.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview ead1e66 has been successfully built and deployed to https://quarkus-pr-main-50454-preview.surge.sh/version/main/guides/
|
e22b044 to
dd2bfcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking great, though I suspect native tests will fail. See below.
I'll launch CI to be sure...
...va/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResourceIT.java
Outdated
Show resolved
Hide resolved
...va/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResourceIT.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResource.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResource.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResource.java
Outdated
Show resolved
Hide resolved
...eployment/src/test/java/io/quarkus/hibernate/orm/config/properties/ConfigPropertiesTest.java
Show resolved
Hide resolved
...va/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResourceIT.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...java/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResource.java
Outdated
Show resolved
Hide resolved
...quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResourceNativeIT.java
Outdated
Show resolved
Hide resolved
f645ccf to
188fdbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @NickBeginner . I made a few changes to fix the tests (see below), squashed, and rebased on main.
I think it's ready to merge if CI passes. Let's see!
...java/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResource.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResource.java
Outdated
Show resolved
Hide resolved
...quarkus/it/jpa/preferredhibernatetypesoverride/OverriddenPreferredTypesResourceNativeIT.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
188fdbc to
0f18e18
Compare
This comment has been minimized.
This comment has been minimized.
0f18e18 to
56e67ae
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Yoann Rodière <[email protected]>
56e67ae to
f64d9d7
Compare
Status for workflow
|
Status for workflow
|
|
It took a few tries, but it finally works :) Merged, thank you @NickBeginner! |
|
@yrodiere great!!!! Thanks to you for the help on understanding how to assert the last two things,I didn't know how to proceed. Thanks a lot 🙏🏻 |

Add Quarkus properties to map the following hibernate properties:
hibernate.type.preferred_duration_jdbc_type : quarkus.hibernate-orm.mapping.duration.preferred_jdbc_type
hibernate.type.preferred_instant_jdbc_type : quarkus.hibernate-orm.mapping.duration.preferred_instant_jdbc_type
hibernate.type.preferred_boolean_jdbc_type : quarkus.hibernate-orm.mapping.preferred.boolean_jdbc_type
hibernate.type.preferred_uuid_jdbc_type : quarkus.hibernate-orm.mapping.preferred.uuid_jdbc_type
Fixes Support properties
hibernate.type.preferred_*_jdbc_type#33328