Skip to content

Conversation

@NickBeginner
Copy link
Contributor

@NickBeginner NickBeginner commented Oct 7, 2025

Add Quarkus properties to map the following hibernate properties:

  • hibernate.type.preferred_duration_jdbc_type : quarkus.hibernate-orm.mapping.duration.preferred_jdbc_type

  • hibernate.type.preferred_instant_jdbc_type : quarkus.hibernate-orm.mapping.duration.preferred_instant_jdbc_type

  • hibernate.type.preferred_boolean_jdbc_type : quarkus.hibernate-orm.mapping.preferred.boolean_jdbc_type

  • hibernate.type.preferred_uuid_jdbc_type : quarkus.hibernate-orm.mapping.preferred.uuid_jdbc_type

  • Fixes Support properties hibernate.type.preferred_*_jdbc_type #33328

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Oct 7, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 7, 2025

/cc @gsmet (hibernate-orm)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I added a few comments below.

@NickBeginner
Copy link
Contributor Author

@yrodiere thanks saw it, is still in draft so I will take them in account while i will be writing the remaining part!

Thanks a lot 🙏🏻

@NickBeginner NickBeginner changed the title add preferred_jdbc_type and preferred_instant_jdbc_type ISSUE-33328 | add PREFERRED_BOOLEAN_JDBC_TYPE, PREFERRED_UUID_JDBC_TYPE, PREFERRED_DURATION_JDBC_TYPE, PREFERRED_INSTANT_JDBC_TYPE properties mapping Oct 9, 2025
@NickBeginner NickBeginner marked this pull request as ready for review October 9, 2025 19:53
@NickBeginner NickBeginner requested a review from yrodiere October 9, 2025 19:54
@NickBeginner
Copy link
Contributor Author

@yrodiere First issue so i don't know if i missed something :)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but the config group stuff and property naming is really off. See my comment in the conversation above for a suggestion on how to do it :)

@gastaldi gastaldi changed the title ISSUE-33328 | add PREFERRED_BOOLEAN_JDBC_TYPE, PREFERRED_UUID_JDBC_TYPE, PREFERRED_DURATION_JDBC_TYPE, PREFERRED_INSTANT_JDBC_TYPE properties mapping Introduce support for hibernate.type.preferred_*_jdbc_type properties Oct 10, 2025
@NickBeginner NickBeginner force-pushed the nbelcastro/issue-33328 branch from 0bacffd to f36b2e2 Compare October 11, 2025 07:46
@NickBeginner NickBeginner requested a review from yrodiere October 11, 2025 07:49
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The properties shouldn't be in application.properties in this case (see below). And ideally it would be great to have an integration test, but I'll let you see if you have time for that :)

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

🎊 PR Preview ead1e66 has been successfully built and deployed to https://quarkus-pr-main-50454-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-33328 branch from e22b044 to dd2bfcf Compare October 14, 2025 19:31
@NickBeginner NickBeginner requested a review from yrodiere October 14, 2025 19:45
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking great, though I suspect native tests will fail. See below.

I'll launch CI to be sure...

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@NickBeginner NickBeginner requested a review from yrodiere October 17, 2025 17:57
@yrodiere yrodiere force-pushed the nbelcastro/issue-33328 branch 2 times, most recently from f645ccf to 188fdbc Compare October 20, 2025 14:31
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @NickBeginner . I made a few changes to fix the tests (see below), squashed, and rebased on main.

I think it's ready to merge if CI passes. Let's see!

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 20, 2025
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@yrodiere yrodiere force-pushed the nbelcastro/issue-33328 branch from 0f18e18 to 56e67ae Compare October 21, 2025 16:28
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@yrodiere yrodiere force-pushed the nbelcastro/issue-33328 branch from 56e67ae to f64d9d7 Compare October 23, 2025 15:34
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f64d9d7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f64d9d7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@yrodiere yrodiere merged commit d3fafc8 into quarkusio:main Oct 24, 2025
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.30 - main milestone Oct 24, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 24, 2025
@yrodiere
Copy link
Member

It took a few tries, but it finally works :) Merged, thank you @NickBeginner!

@NickBeginner
Copy link
Contributor Author

@yrodiere great!!!! Thanks to you for the help on understanding how to assert the last two things,I didn't know how to proceed.

Thanks a lot 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support properties hibernate.type.preferred_*_jdbc_type

3 participants