ncm-network: Restrictions on device naming should match kernel #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is: - Maximum 15 characters (16 including null) - No whitespace - No forward-slashes - No colons (but they _are_ allowed in filenames in order to label alias IPs) While we're at it, make the regexp in the module absolute, as we're actually matching filenames there. Similar validation should also happen in the schema as only throwing errors at runtime is _really_ unfriendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is:
While we're at it, make the regexp in the module absolute, as we're actually matching filenames there.
Similar validation should also happen in the schema as only throwing errors at runtime is really unfriendly.
See also lib/utils.c#L826 and net/core/dev.c#L1066.