Skip to content

Conversation

the-thing
Copy link
Contributor

Fixes #801

The change is backwards compatible since extended message header e.g. quickfix.fix44.Message.Header extends quickfix.Message.Header.

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Sep 24, 2025
@chrjohn
Copy link
Member

chrjohn commented Sep 24, 2025

@the-thing currently AFK, but does this work for the fixlatest messages also? I recall there were some differences regarding code generation. Will check again tomorrow.

@the-thing
Copy link
Contributor Author

the-thing commented Sep 24, 2025

@chrjohn

Good point. I don't think it will work. Let me see if I can fix it.

@chrjohn
Copy link
Member

chrjohn commented Sep 29, 2025

@the-thing , I just published the orchestra tools 1.0.3.
Thanks in advance!

@the-thing the-thing marked this pull request as ready for review September 29, 2025 17:45
@chrjohn chrjohn changed the title quickfix.Message#getHeader subclasses to return Header with respective FIX version header quickfix.Message#getHeader subclasses to return Header with respective FIX version header Sep 30, 2025
@chrjohn
Copy link
Member

chrjohn commented Sep 30, 2025

@the-thing thank you 👍

@chrjohn chrjohn merged commit 2c4f4f1 into quickfix-j:master Sep 30, 2025
12 checks passed
@the-thing the-thing deleted the header-casting branch September 30, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated messages should return header from their fix version
2 participants