Attempt to migrate warp to axum. #5829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started the migration work to test cursor capabilities. As the result was not so bad, I iterated a bit o clean up some horrible pieces of code. And there is the PR.
I expect there is still a lot of refactor to do as I did not have the time to read thoroughtly the axum documentation and find the "right" axum to implement a given handler. I'm notably thinking about how decompression is done.
I did not check lambda and I suggest to remove the module and we don't really want to maintain it for 0.9.
All tests are passing.