Fixed corrupt data bug for sequence creation that created a warning in our treatment planning software #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed a warning message shown after loading an RTStruct in one of our treatment planning software.
This warning can be seen in the following screenshot
We were able to fix this by giving the condition that a CLOSED_PLANAR contour type needs to contain at least 2 data points in order to be added to the contour sequence (this was not always the case and we saw cases where the number of contour points only contained one data point.
We are also aware that the Contour Geometric Type is currently hardcoded in the
create_contourmethod.To future-proof our bug fix we added the
orcondition which would theoretically allow for adding a POINT contour type in the conversion without issues arising from our change.