This repository was archived by the owner on Mar 20, 2025. It is now read-only.
RosterManager: Fix notifying on subscription request with valid old JID #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnjX
reviewed
Mar 18, 2025
|
Lgtm |
The moved XEP discourages auto-acccepting Moved subscriptions, even if they are verified. Now, new verified Moved subscription requests are emitted via subscriptionRequestReceived() like other subscription requests, so the user may accept it. If the JID is not valid, the attribute in the presence is cleared.
If no QXmppMovedManager is registered with the client no verification of Moved old JIDs can be done. To avoid any security accidents here (if clients should forget to add the Moved manager e.g.), always clear the moved old JID in this case. handleStanza() or QXmppClient::presenceReceived() can be used to access the full presence with potentially invalid moved old JIDs. safe-pr
The handling of moved old JIDs and interaction with the QXmppMovedManager was undocumented. This adds documentation, including the behaviour changes between 1.9.4/1.10.1 and 1.9.5/1.10.2.
lnjX
approved these changes
Mar 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR check list:
\since QXmpp 1.X,QXMPP_EXPORTdoc/doap.xmlclang-format -i src/<edited-file(s)> tests/<edited-file(s)>