Fix issue with links using fs::path() (#683) #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pass at addressing the issue referenced in #683 - my understanding of the problem is that the default cli theme is causing the fs_path object to first be rendered as a link and then there is a second pass by
.hrefor.runthat tries to wrap that in a new link and these don't get along.My proposed solution is just a quick check at the beginning of
make_link_href()andmake_link_run()for the presence of an existing link and if detected then usingansi_strip()to remove the existing link before generating the new link. This may be a bit crude, and might nuke other things it shouldn't.There are probably edge cases that I have not considered but I tried testing all of the other link methods and they already had some kind of existing link detection I believe.
Adding
fsto suggests seemed like the path of least resistance but if that is not desirable then it should be avoidable by more carefully constructing the tests.The major issue seems to be resolved but I am not 100% on if the output is exactly as desired in all test cases but everything looked reasonable to me based on the snapshots.