Skip to content

Implement SQL filter #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 2, 2025
Merged

Implement SQL filter #131

merged 14 commits into from
Sep 2, 2025

Conversation

@Gsantomaggio
Copy link
Member

Implement SQL filter

@Gsantomaggio
SQL filter
77cc82e 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio added this to the 0.3.0 milestone Aug 1, 2025
@Gsantomaggio
formatting
835b294 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
change docker iamge
a7cbab6 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Implement filters
eb55784 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Implement filters
7081e43 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Implement filters
46cc79b 
Signed-off-by: Gabriele Santomaggio <[email protected]>
Zerpet
Zerpet previously requested changes Aug 21, 2025
View reviewed changes
Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold ✋ SQL filter test is failing locally with 4.2.0-beta.1

@Zerpet Zerpet force-pushed the feat/sql_expression branch from 46cc79b to 786414d Compare August 22, 2025 12:40
@Gsantomaggio Gsantomaggio marked this pull request as draft August 22, 2025 12:41
@Gsantomaggio
Copy link
Member Author

@Zerpet, yes, I know. It is still WIP. I forgot to put it in draft. Ty

@Zerpet
Copy link
Member

Zerpet commented Aug 22, 2025

@Gsantomaggio no worries, I just pushed a fix 🚀

@Zerpet Zerpet dismissed their stale review August 22, 2025 12:45

Pushed a fix, tests now passing

@Zerpet Zerpet marked this pull request as ready for review August 22, 2025 12:45
@Zerpet Zerpet force-pushed the feat/sql_expression branch from 786414d to 195b1a8 Compare August 22, 2025 12:49
@Zerpet
Copy link
Member

Zerpet commented Aug 25, 2025

this PR requires #132 to pass in Ubuntu

Gsantomaggio and others added 4 commits August 27, 2025 10:53
@Gsantomaggio @Zerpet
SQL filter
e28457f 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio @Zerpet
formatting
5d5857c 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio @Zerpet
change docker iamge
20f7e50 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio @Zerpet
Implement SQL filters
48e8a72 
Signed-off-by: Gabriele Santomaggio <[email protected]>
Co-authored-by: Aitor Perez <[email protected]>
@Zerpet Zerpet force-pushed the feat/sql_expression branch from 195b1a8 to 48e8a72 Compare August 27, 2025 09:53
@Zerpet
Copy link
Member

Zerpet commented Aug 27, 2025 •
edited
Loading

The failure in CI is consistent. I verified locally that RabbitMQ 4.2 beta and main return a different response message for queue declaration. When the queue declare has the stream argument, the response message does not contain the leader field in the AMQP Value response.

Edit: related rabbitmq/rabbitmq-amqp-go-client#45

@Zerpet Zerpet mentioned this pull request Aug 27, 2025
Merged
@Gsantomaggio
comment test
0f7f53f 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
comment test
823d6ff 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
comment test
ad381bf 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
add tests
e40c676 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio merged commit 9435502 into main Sep 2, 2025
3 of 4 checks passed
@Gsantomaggio Gsantomaggio deleted the feat/sql_expression branch September 2, 2025 07:46
@Gsantomaggio Gsantomaggio mentioned this pull request Sep 11, 2025
Closed
@Gsantomaggio Gsantomaggio self-assigned this Sep 17, 2025
@Gsantomaggio Gsantomaggio added the enhancement New feature or request label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zerpet Zerpet Zerpet left review comments

Assignees

@Gsantomaggio Gsantomaggio

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Gsantomaggio @Zerpet