Skip to content

Remove unused Javascript functions #13822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Remove unused Javascript functions #13822

merged 1 commit into from
Apr 28, 2025

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Apr 28, 2025 •
edited
Loading

A security scanner flagged the use of RegExp with unsanitized input. Turns out, these functions are no longer used and can be deleted.

lbakken@shostakovich ~/development/rabbitmq/rabbitmq-server (lukebakken/delete-unused-js $=)
$ git grep getAccessToken

lbakken@shostakovich ~/development/rabbitmq/rabbitmq-server (lukebakken/delete-unused-js $=)
$ git grep getParameterByName

@lukebakken
Remove unused Javascript functions
61b0f15 
A security scanner flagged the use of `RegExp` with unsanitized input.
Turns out, these functions are no longer used and can be deleted.
@lukebakken lukebakken self-assigned this Apr 28, 2025
@michaelklishin
Copy link
Collaborator

@lukebakken that's my favorite type of solution, haha!

@michaelklishin michaelklishin added this to the 4.2.0 milestone Apr 28, 2025
@michaelklishin michaelklishin merged commit 467601a into main Apr 28, 2025
271 checks passed
@michaelklishin michaelklishin deleted the lukebakken/delete-unused-js branch April 28, 2025 23:09
michaelklishin added a commit that referenced this pull request Apr 28, 2025
@michaelklishin
Merge pull request #13823 from rabbitmq/mergify/bp/v4.1.x/pr-13822
a043f00 
Remove unused Javascript functions (backport #13822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels
backport-v4.1.x
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebakken @michaelklishin