Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented May 13, 2025

Proposed Changes

This is a minor change to remove the connection limit and current active count from health checks which returned them (introduced in #13879).

Returning the connection limit and active count are not really necessary for these checks. Instead of returning them in the response to the health check we log a warning when the connection limit is exceeded.

Connects #13782

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

This is an automatic backport of pull request #13888 done by [Mergify](https://mergify.com).

Returning the connection limit and active count are not really necessary
for these checks. Instead of returning them in the response to the
health check we log a warning when the connection limit is exceeded.

(cherry picked from commit 3f53e01)
@the-mikedavis the-mikedavis added this to the 4.1.1 milestone May 13, 2025
@the-mikedavis the-mikedavis merged commit 87b63cb into v4.1.x May 13, 2025
537 of 538 checks passed
@the-mikedavis the-mikedavis deleted the mergify/bp/v4.1.x/pr-13888 branch May 13, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants