Skip to content

CT broker helpers: use rabbitmq-plugins from the given node with a secondary umbrella #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

CT broker helpers: use rabbitmq-plugins from the given node with a secondary umbrella #14057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2375,9 +2375,55 @@ disable_plugin(Config, Node, Plugin) ->
plugin_action(Config, Node, [disable, Plugin]).

plugin_action(Config, Node, Args) ->
Rabbitmqplugins = ?config(rabbitmq_plugins_cmd, Config),
NodeConfig = get_node_config(Config, Node),
Nodename = ?config(nodename, NodeConfig),
%% We want to use the CLI from the given node if there is a secondary
%% umbrella being configured.
I = get_node_index(Config, Node),
CanUseSecondary = (I + 1) rem 2 =:= 0,
WithPlugins0 = rabbit_ct_helpers:get_config(Config,
broker_with_plugins),
WithPlugins = case is_list(WithPlugins0) of
true -> lists:nth(I + 1, WithPlugins0);
false -> WithPlugins0
end,
UseSecondaryDist = case ?config(secondary_dist, Config) of
false -> false;
_ -> CanUseSecondary
end,
UseSecondaryUmbrella = case ?config(secondary_umbrella, Config) of
false ->
false;
_ ->
CanUseSecondary
end,
Rabbitmqplugins = case UseSecondaryUmbrella of
true ->
SrcDir = case WithPlugins of
false ->
?config(
secondary_rabbit_srcdir,
Config);
_ ->
?config(
secondary_current_srcdir,
Config)
end,
SecScriptsDir = filename:join(
[SrcDir, "sbin"]),
rabbit_misc:format(
"~ts/rabbitmq-plugins", [SecScriptsDir]);
false ->
case UseSecondaryDist of
true ->
SecondaryDist = ?config(secondary_dist, Config),
rabbit_misc:format(
"~ts/sbin/rabbitmq-plugins", [SecondaryDist]);
false ->
?config(rabbitmq_plugins_cmd, Config)
end
end,

Env = [
{"RABBITMQ_SCRIPTS_DIR", filename:dirname(Rabbitmqplugins)},
{"RABBITMQ_PID_FILE", ?config(pid_file, NodeConfig)},
Expand Down
Loading