Skip to content

Conversation

Kracken256
Copy link

  • Pack code into cross-platform library
  • Optimized-sub-optimal code
  • Patched race conditions and overflow bugs
  • Added inline documentation for the C API

@trufae
Copy link
Collaborator

trufae commented May 4, 2024

This looks like a hige overhaul of the original code. Can you separate the changes in different commits?

@trufae
Copy link
Collaborator

trufae commented May 4, 2024

And ideally keep the same coding style

@Kracken256
Copy link
Author

I can fix the coding style. But most of the files were changed/removed. Committing individual changes doesn't make much since, there's only like 2 source files and ~15 functions. The new code is ~200x faster (I enabled optimizations).

@trufae
Copy link
Collaborator

trufae commented May 4, 2024

Yeah its a little hard and probably not much useful. Fix the code style and ill merge! Thank you!!

@Kracken256
Copy link
Author

Sorry, I forget about this one. I reformatted the code using Google Style VSCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants