Feat: add twoslash for documentation #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hey, just checking in to say I've not forgotten about this! I tried testing it locally and hit some issues that I need to find time to work out. My goal is to merge this without the "shameless hoisting" setting. So yeah, just wanted to say I'm very appreciative of your work here, and it will eventually land! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds twoslash support in documentation website overall via https://github.com/MatthiesenXYZ/EC-Plugins and also enables it at index page with code examples
Details
This is the first part of contribution, which was discussed here
The second part lands at radashi main repository
I was unable to run website without adding shamefully-hoist, that's why a lockfile differs a lot.
This is how it looks like: https://luminous-elf-a6e4e4.netlify.app/,