getScreenActiveResolution fix #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test137E29B
reviewed
May 8, 2025
| * | ||
| * let batch = mp.game.graphics.createEntityOverlayBatch(overlayParams); | ||
| * | ||
| * |
There was a problem hiding this comment.
Suggested change
| * | |
| * |
This one looks to be mistaken changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function getScreenActiveResolution is currently typed to include x and y as arguments, but this is incorrect. According to the official RAGE Multiplayer Wiki, the function is used without any inputs.
I have tested this in-game and confirmed that it works perfectly fine without any arguments. Additionally, passing values to it does not alter its behavior in any way, which further supports that these inputs are unnecessary and do not belong in the typing.