Bazel: Define a minimal Bazel module #269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defines the very minimal integration with Bazel build system. The definitions follow the spirit of README.md in that the build rules package the library such that it can be included with ```c ```
randy408
reviewed
Jun 21, 2024
| compatibility_level = 1, | ||
| ) | ||
|
|
||
| bazel_dep(name = "zlib", version = "1.3.1") |
There was a problem hiding this comment.
I'm not familiar with bazel, does this specify 1.3.1 and only 1.3.1 or the minimum version?
There was a problem hiding this comment.
If libspng is the only user of zlib in a bazel workspace, then it would mean 1.3.1 exactly.
If there is another bazel_dep with, say, zlib 1.3.2 in its dependencies, then
- if 1.3.1 and 1.3.2 have the same
compatibility_levelin their definition (here: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/zlib/1.3.1/MODULE.bazel#L4 ), the later 1.3.2 version is pulled; - otherwise, the dependency graph cannot be resolved.
Full details:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines the very minimal integration with Bazel build system. The definitions follow the spirit of README.md in that the build rules package the library such that it can be included with