Check the path is set before checking the file exists #20537
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the
#load_metadata
method where if@path_to_user_metadata
was nil, the::File.exists?
check would crash. This was causing an issue on Pro when the Framework was being initialized and for whatever reason the user metadata path wasn't set. It probably makes sense to set the metadata, but given that there's a code path where it's not, we should only be using it when it is. This will at least make sure the framework can be initialized, albeit possibly slower without the cache.Verification
msfconsole