Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to `laravel-livewire-tables` will be documented in this file

## [Unreleased]

## [1.25.2] - 2025-09-06
- Fixed DateTime::getLastErrors() returning false on PHP 8.2+

## [1.25.1] - 2022-03-29

### Changed
Expand Down
19 changes: 10 additions & 9 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,31 +1,32 @@
{
"name": "rappasoft/laravel-livewire-tables",
"name": "markcay/laravel-livewire-tables",
"description": "A dynamic table component for Laravel Livewire",
"keywords": [
"rappasoft",
"livewire",
"datatables",
"tables",
"laravel"
"laravel",
"markcay"
],
"homepage": "https://github.com/rappasoft/laravel-livewire-tables",
"homepage": "https://github.com/markcay/laravel-livewire-tables",
"license": "MIT",
"authors": [
{
"name": "Anthony Rappa",
"email": "rappa819@gmail.com",
"name": "Mark Cay",
"email": "markgabrieller@gmail.com",
"role": "Developer"
}
],
"require": {
"php": "^7.4|^8.0",
"livewire/livewire": "^2.6",
"php": "^8.1",
"livewire/livewire": "^3.0",
"spatie/laravel-package-tools": "^1.4.3",
"illuminate/contracts": "^8.0|^9.0"
"illuminate/contracts": "^8.0|^9.0|^10.0"
},
"require-dev": {
"ext-sqlite3": "*",
"orchestra/testbench": "^6.13|^7.0",
"orchestra/testbench": "^6.13|^7.0|^8.0",
"phpunit/phpunit": "^9.3",
"spatie/laravel-ray": "^1.9",
"vimeo/psalm": "^4.4"
Expand Down
12 changes: 10 additions & 2 deletions src/Traits/WithFilters.php
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,25 @@ public function cleanFilters(): void
// did not do "month shifting"
// (e.g. consider that January 32 is February 1)
$dt = DateTime::createFromFormat("Y-m-d", $filterValue);
$lastErrors = $dt::getLastErrors();
if ($lastErrors === false) {
$lastErrors = [];
}

return $dt !== false && ! array_sum($dt::getLastErrors());
return $dt !== false && ! array_sum($lastErrors);
}

if ($filterDefinitions[$filterName]->isDatetime()) {
// array_sum trick is a terse way of ensuring that PHP
// did not do "month shifting"
// (e.g. consider that January 32 is February 1)
$dt = DateTime::createFromFormat("Y-m-d\TH:i", $filterValue);
$lastErrors = $dt::getLastErrors();
if ($lastErrors === false) {
$lastErrors = [];
}

return $dt !== false && ! array_sum($dt::getLastErrors());
return $dt !== false && ! array_sum($lastErrors);
}

return false;
Expand Down
20 changes: 20 additions & 0 deletions tests/Unit/DateTimeTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

namespace Tests\Unit;

use PHPUnit\Framework\TestCase;

class DateTimeTest extends TestCase
{
public function testValidDateHasNoErrors()
{
$dt = \DateTime::createFromFormat('Y-m-d', '2025-09-06');
$errors = \DateTime::getLastErrors();

// PHP 8.2+: false | pre-8.2: array
$this->assertTrue(
$errors === false || (is_array($errors) && array_sum($errors) === 0),
'Valid date should not produce DateTime errors'
);
}
}