Added 24LC32 EEPROM I2C example #709
Conversation
i2c/24lc32_i2c/24lc32_i2c_lib.h
Outdated
| void read_eeprom(uint16_t address, uint8_t *result, uint16_t num, uint8_t i2c_addr); | ||
| void byte_write_eeprom(uint16_t address, uint8_t data, uint8_t i2c_addr); | ||
| bool page_write_eeprom(uint16_t address, uint8_t *data, uint8_t num, uint8_t i2c_addr); |
There was a problem hiding this comment.
Only a gut-feeling, but I wonder if uint8_t i2c_addr ought to be the first parameter? (Or the second parameter, if you also add i2c_inst_t *i2c_instance?)
Probably worth checking with @peterharperuk what style he prefers.
| uint8_t byte1 = (uint8_t)(address >> 8); | ||
| uint8_t byte2 = (uint8_t)(address); | ||
|
|
||
| uint8_t buf[2] = {byte1, byte2}; |
There was a problem hiding this comment.
@peterharperuk Should these variables be declared outside of the for loop, or does that not really matter?
There was a problem hiding this comment.
It looks like it makes more sense as it is here?
|
Could you rename |
Louis31423142
force-pushed
the
24lc32
branch
from
b7de1f4 to
021bbec
Compare
|
Eeek, looks like you've overwritten |
Louis31423142
force-pushed
the
24lc32
branch
from
021bbec to
9d44cad
Compare
Louis31423142
force-pushed
the
24lc32
branch
3 times, most recently
from
a0147e0 to
7514659
Compare
Louis31423142
force-pushed
the
24lc32
branch
from
7514659 to
335ef9c
Compare
Louis31423142
force-pushed
the
24lc32
branch
from
335ef9c to
7ee16d8
Compare
| // This is the max number of bytes which can be written at once during a page write | ||
| #define MAX_PAGE_WRITE 32 | ||
|
|
||
| // This is the 24LC32's capacity in bytes | ||
| #define EEPROM_SIZE 4096 |
There was a problem hiding this comment.
@peterharperuk Would it make sense for these to be in the .h file rather than the .c file? 🤷♂️
There was a problem hiding this comment.
There may be a way to query the hardware for these values rather than hard code them. But maybe this is good enough for this example
|
Looks pretty good to me now 👍 |
| @@ -159,6 +159,7 @@ App|Description | |||
| [ht16k33_i2c](i2c/ht16k33_i2c) | Drive a 4 digit 14 segment LED with an HT16K33. | |||
| [slave_mem_i2c](i2c/slave_mem_i2c) | i2c slave example where the slave implements a 256 byte memory. | |||
| [slave_mem_i2c_burst](i2c/slave_mem_i2c) | i2c slave example where the slave implements a 256 byte memory. This version inefficiently writes each byte in a separate call to demonstrate read and write burst mode. | |||
| [24lc32_i2c](i2c/24lc32_i2c) | Read and write data to 24LC32 EEPROM via I2C. | |||
There was a problem hiding this comment.
arguably missing an "a "
No description provided.