RDoc-3494 Feature-specific page #2125
Conversation
templates/introduction.mdx
Outdated
| @@ -0,0 +1,198 @@ | |||
| import CardWithImage from '@site/src/components/Common/CardWithImage'; | |||
There was a problem hiding this comment.
| import CardWithImage from '@site/src/components/Common/CardWithImage'; | |
| --- | |
| title: "AI Overview" | |
| hide_table_of_contents: true | |
| sidebar_label: AI Overview | |
| --- | |
| import CardWithImage from '@site/src/components/Common/CardWithImage'; |
src/components/Common/Button.tsx
Outdated
| @@ -43,16 +49,21 @@ export default function Button({ | |||
| ); | |||
|
|
|||
| if (url) { | |||
| const external = !isInternalUrl(url); | |||
There was a problem hiding this comment.
| const external = !isInternalUrl(url); | |
| const isExternal = !isInternalUrl(url); |
| const pluginId = "default"; | ||
| const { activeVersion } = useActiveDocContext(pluginId); | ||
|
|
||
| if (minimumVersion > activeVersion.label) { |
There was a problem hiding this comment.
You are comparing string values, not number. It can be very tricky
e.g. "7.0">"7" == true
Use number values to compare.
Also it looks like the naming or condition is wrong. When minimumVersion is greater than activeVersion we do not render children?
There was a problem hiding this comment.
@kalczur please verify the code, but it appears to be working just fine
There was a problem hiding this comment.
In these scenarios yes, but check e.g.
"10.1" > "9.9"
JavaScript compares the string sign by sign
src/components/OneColGrid.tsx
Outdated
| lg: "gap-8", | ||
| }; | ||
|
|
||
| export default function OneColGrid({ |
There was a problem hiding this comment.
Can we make one component with colCount props instead of creating new component for each scenario?
mateuszbartosik
force-pushed
the
RDoc-3494
branch
from
2f084ef to
62babfd
Compare
No description provided.