[fix] Fix MC Sink Empty Message When Parsing

README.md

@@ -47,21 +47,21 @@ $ ./gradlew clean
 ```xml
 
 <dependency>
-    <groupId>io.odpf</groupId>
+    <groupId>com.gotocompany</groupId>
     <artifactId>depot</artifactId>
     <version>version</version>
 </dependency>
 ```
 
 ```sh
-implementation group: 'io.odpf', name: 'depot', version: 'version'
+implementation group: 'com.gotocompany', name: 'depot', version: 'version'
 ```
 
 ### Usage example:
 
 ```java
-public interface OdpfSink extends Closeable {
-    OdpfSinkResponse pushToSink(List<OdpfMessage> messages) throws OdpfSinkException;
+public interface Sink extends Closeable {
+    SinkResponse pushToSink(List<Message> messages) throws SinkException;
 }
 ```
 
@@ -87,12 +87,12 @@ class MyClass {
 
 ### Data types
 
-Currently, sink connector library is supporting protobuf and Json format. We can set the datatype of `OdpfMessage` by
+Currently, sink connector library is supporting protobuf and Json format. We can set the datatype of `Message` by
 setting `SINK_CONNECTOR_SCHEMA_DATA_TYPE`. Each datatype has parsers which takes care of deserialization.
 
 ### Adding a new Sink
 
-Each sink will have to implement `OdpfSink` interface. The pushToSink take a batch of messages and return a response
+Each sink will have to implement `Sink` interface. The pushToSink take a batch of messages and return a response
 with error list.
 
 ### Configurations

build.gradle

@@ -3,8 +3,8 @@ buildscript {
         maven { url 'https://plugins.gradle.org/m2/' }
     }
     dependencies {
-        classpath 'com.google.protobuf:protobuf-gradle-plugin:0.8.17'
-        classpath "org.jfrog.buildinfo:build-info-extractor-gradle:4.4.7"
+        classpath 'com.google.protobuf:protobuf-gradle-plugin:0.9.4'
+        classpath "org.jfrog.buildinfo:build-info-extractor-gradle:4.33.1"
         classpath "org.ajoberstar:gradle-git:1.6.0"
     }
 }
@@ -14,44 +14,61 @@ plugins {
     id 'idea'
     id 'checkstyle'
     id 'jacoco'
-    id "com.google.protobuf" version "0.8.17"
+    id "com.google.protobuf" version "0.9.4"
     id 'io.franzbecker.gradle-lombok' version '5.0.0'
     id 'maven-publish'
     id 'signing'
     id "io.github.gradle-nexus.publish-plugin" version "1.1.0"
 }
 
-group 'io.odpf'
-version '0.3.8'
+group 'com.gotocompany'
+version '0.10.12'
 
 repositories {
-    mavenCentral()
     mavenLocal()
+    mavenCentral()
 }
 
+configurations.configureEach { exclude group: 'com.google.guava', module: 'listenablefuture' }
+
 dependencies {
-    implementation group: 'com.google.protobuf', name: 'protobuf-java', version: '3.1.0'
+    implementation group: 'com.google.protobuf', name: 'protobuf-java', version: '3.25.0'
     implementation group: 'com.datadoghq', name: 'java-dogstatsd-client', version: '2.13.0'
-    implementation group: 'com.google.protobuf', name: 'protobuf-java-util', version: '3.1.0'
-    implementation group: 'io.odpf', name: 'stencil', version: '0.2.1' exclude group: 'org.slf4j'
+    implementation group: 'com.google.protobuf', name: 'protobuf-java-util', version: '3.25.0'
+    implementation group: 'com.gotocompany', name: 'stencil', version: '0.6.0' exclude group: 'org.slf4j'
     implementation group: 'org.aeonbits.owner', name: 'owner', version: '1.0.9'
-    implementation 'com.google.cloud:google-cloud-bigquery:1.115.0'
-    implementation (group: 'com.google.cloud', name:'google-cloud-bigtable', version:'2.11.2') {
+    implementation (group: 'com.google.cloud', name: 'google-cloud-bigquerystorage', version: '2.39.1') {
+        exclude group: "io.grpc"
+    }
+    implementation(group: 'com.google.cloud', name: 'google-cloud-bigquery', version: '2.29.0') {
         exclude group: "io.grpc"
     }
-    implementation "io.grpc:grpc-all:1.38.0"
+    implementation(group: 'com.google.cloud', name: 'google-cloud-bigtable', version: '2.24.1') {
+        exclude group: "io.grpc"
+    }
+    implementation (group: 'com.aliyun.odps', name: 'odps-sdk-core', version: '0.51.10-public') {
+        exclude group: "com.google"
+        exclude group: "io.grpc"
+        exclude group: "org.slf4j"
+    }
+    implementation 'io.grpc:grpc-all:1.55.1'
     implementation group: 'org.slf4j', name: 'jul-to-slf4j', version: '1.7.35'
-    implementation group: 'redis.clients', name: 'jedis', version: '3.0.1'
+    implementation group: 'redis.clients', name: 'jedis', version: '3.10.0'
     implementation group: 'org.apache.commons', name: 'commons-lang3', version: '3.5'
-    implementation 'com.fasterxml.jackson.core:jackson-databind:2.13.2.1'
-    implementation 'org.json:json:20220320'
-    implementation group: 'com.jayway.jsonpath', name: 'json-path', version: '2.4.0'
-    testImplementation group: 'junit', name: 'junit', version: '4.13'
+    implementation 'com.fasterxml.jackson.core:jackson-databind:2.15.2'
+    implementation 'org.json:json:20230227'
+    implementation group: 'com.jayway.jsonpath', name: 'json-path', version: '2.8.0'
+    implementation group: 'com.squareup.okhttp3', name: 'okhttp', version: '4.9.1'
+    implementation group: 'joda-time', name: 'joda-time', version: '2.10.2'
+    implementation('com.google.guava:guava:32.0.1-jre') { force = true }
+    testImplementation group: 'junit', name: 'junit', version: '4.13.1'
+    testImplementation group: 'org.assertj', name: 'assertj-core', version: '3.26.3'
     testImplementation 'org.hamcrest:hamcrest-all:1.3'
     testImplementation 'org.mockito:mockito-core:4.5.1'
-    testImplementation "com.github.tomakehurst:wiremock:2.3.1"
+    testImplementation 'com.github.tomakehurst:wiremock:2.16.0'
+    testImplementation group: 'org.skyscreamer', name: 'jsonassert', version: '1.5.1'
     testImplementation group: 'io.opentracing', name: 'opentracing-mock', version: '0.33.0'
-    testImplementation group: 'org.mock-server', name: 'mockserver-netty', version: '3.10.5'
+    testImplementation group: 'org.mock-server', name: 'mockserver-netty', version: '5.15.0'
     testImplementation gradleTestKit()
     testImplementation 'org.junit.jupiter:junit-jupiter:5.7.0'
     testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.2'
@@ -93,15 +110,17 @@ idea {
         testSourceDirs += file("$projectDir/src/generated/test/java")
     }
 }
+sourceCompatibility = JavaVersion.VERSION_1_8
+targetCompatibility = JavaVersion.VERSION_1_8
 
 protobuf {
     generatedFilesBaseDir = "$projectDir/src/generated"
     protoc {
-        artifact = "com.google.protobuf:protoc:3.1.0"
+        artifact = "com.google.protobuf:protoc:3.25.0"
     }
     plugins {
         grpc {
-            artifact = "io.grpc:protoc-gen-grpc-java:1.0.3"
+            artifact = "io.grpc:protoc-gen-grpc-java:1.59.0"
         }
     }
     generateProtoTasks {
@@ -142,10 +161,10 @@ publishing {
                 version = project.version
                 name = 'Depot'
                 description = 'A sink connector library containing multiple sink implementations'
-                url = 'https://github.com/odpf/depot'
+                url = 'https://github.com/goto/depot'
 
                 scm {
-                    url = 'https://github.com/odpf/depot.git'
+                    url = 'https://github.com/goto/depot.git'
                 }
 
                 licenses {
@@ -168,7 +187,9 @@ publishing {
 }
 
 signing {
-    sign publishing.publications.maven
+    if (!project.hasProperty('local')) {
+        sign publishing.publications.maven
+    }
 }
 
 nexusPublishing {
@@ -191,7 +212,10 @@ jacocoTestCoverageVerification {
                               '**/serializer/**',
                               '**/cortexpb/**',
                               '**/Clock**',
-                              '**/GoGoProtos**',])
+                              '**/GoGoProtos**',
+                              '**/MaxComputeClient**',
+                              '**/MaxComputeSinkFactory**',
+                              ''])
         })
     }
     violationRules {

docs/README.md

@@ -49,21 +49,21 @@ $ ./gradlew clean
 ```xml
 
 <dependency>
-    <groupId>io.odpf</groupId>
+    <groupId>com.gotocompany</groupId>
     <artifactId>depot</artifactId>
     <version>version</version>
 </dependency>
 ```
 
 ```sh
-implementation group: 'io.odpf', name: 'depot', version: 'version'
+implementation group: 'com.gotocompany', name: 'depot', version: 'version'
 ```
 
 ### Usage example:
 
 ```java
-public interface OdpfSink extends Closeable {
-    OdpfSinkResponse pushToSink(List<OdpfMessage> messages) throws OdpfSinkException;
+public interface Sink extends Closeable {
+    SinkResponse pushToSink(List<Message> messages) throws SinkException;
 }
 ```
 
@@ -89,12 +89,12 @@ class MyClass {
 
 ### Data types
 
-Currently, sink connector library is supporting protobuf and Json format. We can set the datatype of `OdpfMessage` by
+Currently, sink connector library is supporting protobuf and Json format. We can set the datatype of `Message` by
 setting `SINK_CONNECTOR_SCHEMA_DATA_TYPE`. Each datatype has parsers which takes care of deserialization.
 
 ### Adding a new Sink
 
-Each sink will have to implement `OdpfSink` interface. The pushToSink take a batch of messages and return a response
+Each sink will have to implement `Sink` interface. The pushToSink take a batch of messages and return a response
 with error list.
 
 ### Configurations

docs/SUMMARY.md

@@ -6,13 +6,20 @@
 ## Sink
 * [Bigquery](sinks/bigquery.md)
 * [Redis](sinks/redis.md)
+* [Bigtable](sinks/bigtable.md)
+* [HTTP](sinks/http-sink.md)
+
 
 ## Reference
 
 * [Configuration](reference/configuration/README.md)
   * [Generic](reference/configuration/generic.md)
   * [Stencil Client](reference/configuration/stencil-client.md)
   * [Bigquery Sink](reference/configuration/bigquery-sink.md)
+  * [Redis Sink](reference/configuration/redis.md)
+  * [Bigtable Sink](reference/configuration/bigtable.md)
+  * [HTTP Sink](reference/configuration/http-sink.md)
+
 * [Metrics](reference/metrics.md)
 
 ## Contribute

docs/contribute/contribution.md

@@ -2,7 +2,7 @@
 
 The following is a set of guidelines for contributing to Depot. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request. Here are some important resources:
 
-* Github [issues](https://github.com/odpf/depot/issues) track the ongoing and reported issues.
+* Github [issues](https://github.com/goto/depot/issues) track the ongoing and reported issues.
 
 Development of Depot happens in the open on GitHub, and we are grateful to the community for contributing bug fixes and improvements. Read below to learn how you can take part in improving Depot.
 
@@ -53,5 +53,5 @@ Please follow these practices for your change to get merged fast and smoothly:
 * If you are introducing a completely new feature or making any major changes to an existing one, we recommend starting with an RFC and get consensus on the basic design first.
 * Make sure your local build is running with all the tests and checkstyle passing.
 * If your change is related to user-facing protocols/configurations, you need to make the corresponding change in the documentation as well.
-* Docs live in the code repo under [`docs`](https://github.com/odpf/depot/tree/main/docs/README.md) so that changes to that can be done in the same PR as changes to the code.
+* Docs live in the code repo under [`docs`](https://github.com/goto/depot/tree/main/docs/README.md) so that changes to that can be done in the same PR as changes to the code.
 

docs/contribute/development.md

@@ -24,23 +24,23 @@ Environment variables can be configured in the following way -
 * run  `export SAMPLE_VARIABLE=287` on a UNIX shell, to directly assign the required environment variable.
 
 ### Custom application 
-We need to create an application which has io.odpf.depot as a dependency.
+We need to create an application which has com.gotocompany.depot as a dependency.
 This application will create any sink that a developer wants to test by using sink-factories. 
-The OdpfSink's APIs can be used to send data to sinks and check the response. 
+The Sink's APIs can be used to send data to sinks and check the response. 
 One can setup monitoring to see metrics emitted too.
 #### Maven and gradle dependency
 
 ```xml
 
 <dependency>
-    <groupId>io.odpf</groupId>
+    <groupId>com.gotocompany</groupId>
     <artifactId>depot</artifactId>
     <version>version</version>
 </dependency>
 ```
 
 ```sh
-implementation group: 'io.odpf', name: 'depot', version: 'version'
+implementation group: 'com.gotocompany', name: 'depot', version: 'version'
 ```
 #### Sample Application
 ```java
@@ -75,7 +75,7 @@ The environment variable `SCHEMA_REGISTRY_STENCIL_ENABLE` must be set to `true`
 Stencil server URL must be specified in the variable `SCHEMA_REGISTRY_STENCIL_URLS` . 
 The Proto Descriptor Set file of the messages must be uploaded to the Stencil server.
 
-Refer [this guide](https://github.com/odpf/stencil/tree/master/server#readme) on how to set up and configure the Stencil server, and how to generate and upload Proto descriptor set file to the server.
+Refer [this guide](https://github.com/goto/stencil/tree/master/server#readme) on how to set up and configure the Stencil server, and how to generate and upload Proto descriptor set file to the server.
 
 ### Monitoring
 
@@ -89,10 +89,10 @@ Following are the typical requirements:
 
 
 ### Adding a new Sink
-To add a new sink implementation the Sink class has to implement OdpfSink interface 
+To add a new sink implementation the Sink class has to implement Sink interface 
 ```java
-public interface OdpfSink extends Closeable {
-    OdpfSinkResponse pushToSink(List<OdpfMessage> messages) throws OdpfSinkException;
+public interface Sink extends Closeable {
+    SinkResponse pushToSink(List<Message> messages) throws SinkException;
 }
 ```
 Sink implementations will normally have a factory class too which will be used to setup and create objects of Impl classes. 

docs/reference/configuration/README.md

@@ -9,4 +9,5 @@ This page contains reference for all the configurations for sink connectors.
 * [Bigquery Sink](bigquery-sink.md)
 * [Redis Sink](redis.md)
 * [Bigtable Sink](bigtable.md)
+* [HTTP Sink](http-sink.md)