-
Couldn't load subscription status.
- Fork 10
RDKEMW-6167: Update Display Settings with libds client library #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common observation, in all event notification callbacks, I see there is a check for being valid DisplaySettings::_instance. We should really try and understand what use case will we hit the issue, and please document the usecase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see deletion of old static methods (originally receiving notification over IARM).
Also make sure dsMgr.h and other unused headers are no more included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the DisplaySettings plugin from IARM-based event handling to a device library-based event handling system. The change replaces legacy IARM event registration and handlers with modern C++ interface implementations for better type safety and maintainability.
Key changes:
- Replaces IARM event handlers with device library interface implementations
- Adds multiple interface inheritance for handling different types of display and audio events
- Refactors initialization and deinitialization logic to use device::Manager instead of IARM
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DisplaySettings.h | Adds interface inheritance and declares new event handler methods while removing IARM function declarations |
| DisplaySettings.cpp | Implements new device library event handlers and removes IARM-based event handling code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
sync with develop branch
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Signed-off-by: Dosakaya <[email protected]>
Reason for change: Update Display Settings with libds client library.
Test Procedure: test all end-to-end tests for all new events
Risks: NO
Priority: P1