Skip to content

RDKEMW-6515: Scan and Fix coverity issues of Entservices and rdkservices-cpc #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-6515: Scan and Fix coverity issues of Entservices and rdkservices-cpc #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aace223
RDKEMW-6515: Scan and Fix coverity issues of Entservices and rdkservi…
agampa263 Sep 10, 2025
9bde17b
RDKEMW-6515: Scan and Fix coverity issues of Entservices and rdkservi…
agampa263 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions DisplaySettings/DisplaySettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**

Check failure on line 1 in DisplaySettings/DisplaySettings.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'DisplaySettings/DisplaySettings.cpp' (Match: rdkcentral/rdkservices/866, 6106 lines, url: https://github.com/rdkcentral/rdkservices/archive/AML_BSP_VERSION_866.tar.gz, file: DisplaySettings/DisplaySettings.cpp)

Check failure on line 1 in DisplaySettings/DisplaySettings.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'DisplaySettings/DisplaySettings.cpp' (Match: rdkcentral/rdkservices/1, 6106 lines, url: https://github.com/rdkcentral/rdkservices/archive/GRT_v1.tar.gz, file: DisplaySettings/DisplaySettings.cpp)
* If not stated otherwise in this file or this component's LICENSE
* file the following copyright and licenses apply:
*
Expand Down Expand Up @@ -856,6 +856,19 @@
}
}

int DisplaySettings::getAudioDeviceSADState(void) {
//function used to read the current SAD state with lock
std::lock_guard<std::mutex> lock(m_SadMutex);
return m_AudioDeviceSADState;
}

void DisplaySettings::setAudioDeviceSADState(int newState) {
// function used to set the required SAD state with lock
std::lock_guard<std::mutex> lock(m_SadMutex);
LOGINFO("Updating SAD State [%d] -> [%d] ", m_AudioDeviceSADState,newState);
m_AudioDeviceSADState = newState;
}

void DisplaySettings::dsHdmiEventHandler(const char *owner, IARM_EventId_t eventId, void *data, size_t len)
{
switch (eventId)
Expand Down Expand Up @@ -4389,9 +4402,9 @@
if ((mode == device::AudioStereoMode::kPassThru) || (aPort.getStereoAuto() == true))
{
{
std::lock_guard<std::mutex> lock(m_SadMutex);
/* Take actions according to SAD udpate state */
switch(m_AudioDeviceSADState)
int currentSADState = getAudioDeviceSADState();
switch(currentSADState)
{
case AUDIO_DEVICE_SAD_UPDATED:
{
Expand All @@ -4404,7 +4417,7 @@
case AUDIO_DEVICE_SAD_RECEIVED:
{
LOGINFO("%s: Update Audio device SAD\n", __FUNCTION__);
m_AudioDeviceSADState = AUDIO_DEVICE_SAD_UPDATED;
setAudioDeviceSADState(AUDIO_DEVICE_SAD_UPDATED);
aPort.setSAD(sad_list);

if(aPort.getStereoAuto() == true) {
Expand Down Expand Up @@ -4435,7 +4448,7 @@

default:
{
LOGINFO("Incorrect Audio Deivce SAD state %d\n", m_AudioDeviceSADState); // should not hit this case
LOGINFO("Incorrect Audio Deivce SAD state %d\n", currentSADState); // should not hit this case
}
break;
}
Expand Down Expand Up @@ -4936,14 +4949,15 @@
LOGERR("Field 'status' could not be found in the event's payload.");
return;
}

std::lock_guard<std::mutex> lock(m_AudioDeviceStatesUpdateMutex);
LOGINFO("ARC routing state before update m_currentArcRoutingState=%d\n ", m_currentArcRoutingState);
// AVR power status is not checked here assuming that ARC init request will happen only when AVR is in ON state
if ((m_currentArcRoutingState != ARC_STATE_ARC_INITIATED) && (m_systemAudioMode_Power_RequestedAndReceived == true)) {
value = parameters["status"].String();

if( !value.compare("success") ) {
//Update Arc state
std::lock_guard<std::mutex> lock(m_AudioDeviceStatesUpdateMutex);
m_currentArcRoutingState = ARC_STATE_ARC_INITIATED;
//Request SAD
// We will get Arc initiation request only if port is connected and Audio device is detected
Expand Down Expand Up @@ -4991,7 +5005,6 @@
else{
LOGERR("CEC ARC Initiaition Failed !!!");
{
std::lock_guard<std::mutex> lock(m_AudioDeviceStatesUpdateMutex);
m_currentArcRoutingState = ARC_STATE_ARC_TERMINATED;
}//Release Mutex m_AudioDeviceStatesUpdateMutex if Arc failure
}
Expand All @@ -5018,11 +5031,11 @@
LOGINFO("SAD already cleared\n");
}

std::lock_guard<std::mutex> lock(m_AudioDeviceStatesUpdateMutex);
LOGINFO("Current ARC routing state before update m_currentArcRoutingState=%d\n ", m_currentArcRoutingState);
if (m_currentArcRoutingState != ARC_STATE_ARC_TERMINATED) {
if (parameters.HasLabel("status")) {
value = parameters["status"].String();
std::lock_guard<std::mutex> lock(m_AudioDeviceStatesUpdateMutex);
m_currentArcRoutingState = ARC_STATE_ARC_TERMINATED;
m_requestSadRetrigger = false;
LOGINFO("Current ARC routing state after update m_currentArcRoutingState=%d\n ", m_currentArcRoutingState);
Expand Down Expand Up @@ -5066,11 +5079,11 @@

if (parameters.HasLabel("ShortAudioDescriptor")) {
shortAudioDescriptorList = parameters["ShortAudioDescriptor"].Array();
if (m_AudioDeviceSADState == AUDIO_DEVICE_SAD_REQUESTED) {
int currentSADState = getAudioDeviceSADState();
if (currentSADState == AUDIO_DEVICE_SAD_REQUESTED) {
try
{
std::lock_guard<std::mutex> lock(m_SadMutex);
m_AudioDeviceSADState = AUDIO_DEVICE_SAD_RECEIVED;
setAudioDeviceSADState(AUDIO_DEVICE_SAD_RECEIVED);
m_requestSadRetrigger = false;
device::AudioOutputPort aPort = device::Host::getInstance().getAudioOutputPort("HDMI_ARC0");
LOGINFO("Total Short Audio Descriptors received from connected ARC device: %d\n",shortAudioDescriptorList.Length());
Expand All @@ -5097,7 +5110,7 @@

if (wasSADTimerActive == true && m_arcEarcAudioEnabled == false ) { /*setEnableAudioPort is called, Timer has started, got SAD before Timer Expiry*/
LOGINFO("%s: Updating SAD \n", __FUNCTION__);
m_AudioDeviceSADState = AUDIO_DEVICE_SAD_UPDATED;
setAudioDeviceSADState(AUDIO_DEVICE_SAD_UPDATED);
aPort.setSAD(sad_list);
if(aPort.getStereoAuto() == true) {
aPort.setStereoAuto(true,true);
Expand All @@ -5113,7 +5126,7 @@
m_arcEarcAudioEnabled = true;
} else if (m_arcEarcAudioEnabled == true) { /*setEnableAudioPort is called,Timer started and Expired, arc is routed -- or for both wasSADTimerActive == true/false*/
LOGINFO("%s: Updating SAD since audio is already routed and ARC is initiated\n", __FUNCTION__);
m_AudioDeviceSADState = AUDIO_DEVICE_SAD_UPDATED;
setAudioDeviceSADState(AUDIO_DEVICE_SAD_UPDATED);
aPort.setSAD(sad_list);
if(aPort.getStereoAuto() == true) {
aPort.setStereoAuto(true,true);
Expand Down
2 changes: 2 additions & 0 deletions DisplaySettings/DisplaySettings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/**

Check failure on line 1 in DisplaySettings/DisplaySettings.h

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'DisplaySettings/DisplaySettings.h' (Match: rdkcentral/rdkservices/1, 369 lines, url: https://github.com/rdkcentral/rdkservices/archive/GRT_v1.tar.gz, file: DisplaySettings/DisplaySettings.h)
* If not stated otherwise in this file or this component's LICENSE
* file the following copyright and licenses apply:
*
Expand Down Expand Up @@ -265,6 +265,8 @@
bool sendHdmiCecSinkAudioDevicePowerOn();
bool getHdmiCecSinkCecEnableStatus();
bool getHdmiCecSinkAudioDeviceConnectedStatus();
int getAudioDeviceSADState(void);
void setAudioDeviceSADState(int newState);

void onTimer();
void stopCecTimeAndUnsubscribeEvent();
Expand Down
Loading