Skip to content

RDK-E - getDeviceInfo is returning make as Xumo (#401) #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDK-E - getDeviceInfo is returning make as Xumo (#401) #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8975d
RDK-E - getDeviceInfo is returning make as Xumo (#401)
nanimatta Sep 3, 2025
e22bdfe
Merge branch 'develop' into topic/RDKEMW-7273_dev
Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions SystemServices/SystemServices.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*
* Copyright 2025 RDK Management
*
* Licensed under the Apache License, Version 2.0 (the "License");

Check failure on line 7 in SystemServices/SystemServices.cpp

View workflow job for this annotation

GitHub Actions / call-fossid-workflow / Fossid Annotate PR

FossID License Issue Detected 

Source code with 'Apache-2.0' license found in local file 'SystemServices/SystemServices.cpp' (Match: rdkcentral/rdkservices/1, 5268 lines, url: https://github.com/rdkcentral/rdkservices/archive/GRT_v1.tar.gz, file: SystemServices/SystemServices.cpp)
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
Expand Down Expand Up @@ -1129,7 +1129,26 @@

// there is no /tmp/.make from /lib/rdk/getDeviceDetails.sh, but it can be taken from /etc/device.properties
if (queryParams.empty() || queryParams == "make") {

std::string device_name{};
GetValueFromPropertiesFile(DEVICE_PROPERTIES_FILE, "DEVICE_NAME", device_name);
if (device_name == "PLATCO") {
IARM_Bus_MFRLib_GetSerializedData_Param_t param;
memset(&param, 0, sizeof(param));
param.type = mfrSERIALIZED_TYPE_MANUFACTURER;

IARM_Result_t result = IARM_Bus_Call(IARM_BUS_MFRLIB_NAME, IARM_BUS_MFRLIB_API_GetSerializedData, &param, sizeof(param));
param.buffer[param.bufLen] = '\0';
LOGINFO("SystemService getDeviceInfo param type %d result %s bufLen = %d", param.type, param.buffer, param.bufLen);

if (result == IARM_RESULT_SUCCESS) {
response["make"] = string(param.buffer);
retAPIStatus = true;
} else {
LOGERR("IARM_BUS_MFRLIB_API_GetSerializedData call was failed");
populateResponseWithError(SysSrv_MissingKeyValues, response); // Set an error in the response
retAPIStatus = false;
}
} else {
std::string make;
GetValueFromPropertiesFile(DEVICE_PROPERTIES_FILE, "MFG_NAME", make);

Expand All @@ -1139,7 +1158,7 @@
} else {
populateResponseWithError(SysSrv_MissingKeyValues, response);
}

}
if (!queryParams.empty()) {


Expand Down
Loading