add fixes for 'allocate command' #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zghp
added this to the
xts_allocator_server 1.2.0: Store and return device and rack config data milestone
TB-1993
reviewed
Oct 23, 2025
routes/allocation_routes.py
Outdated
| query = query.filter(Device.tags.contains(tags)) | ||
| slot = query.first() | ||
| if not slot: | ||
| return json({"message": "No free slot matches the criteria"}, status=404) |
There was a problem hiding this comment.
No sure 404 is correct here. It probably should be some form of 500 error.
This error also gets suppressed by the client and isn't displayed, which would be nice to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.