Feature/complete list logic and implement tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype of dataKey does not match state`
PejmanNik
suggested changes
Nov 26, 2019
src/components/List/index.tsx
Outdated
| export interface Props<T, U = T, V extends EmptyProps = EmptyProps> | ||
| extends ListRowsProps<T, U> { | ||
| className?: string; | ||
| Container?: ComponentType<{ className?: string; children: ReactNode }> | ElementType; |
There was a problem hiding this comment.
I think ElementType just cause type checking ignoring ComponentType<{ className?: string; children: ReactNode }>. can't we cast div to solve the problem?
There was a problem hiding this comment.
You are right about type checking issue, I fixed this prop type. Now it's possible to set all HTML tags + valid react components that have required props.
Are you Ok with this idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.