chore: migrate from ora to nanospinner
#2640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
requested review from
cipolleschi,
cortinico,
thymikee and
szymonrybczak
as code owners
wojtekmaj
force-pushed
the
wmaj/nanospinner
branch
from
42f5ff9 to
5c2826f
Compare
wojtekmaj
force-pushed
the
wmaj/nanospinner
branch
from
5c2826f to
6cc9fcc
Compare
wojtekmaj
force-pushed
the
wmaj/nanospinner
branch
from
6cc9fcc to
d24109d
Compare
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the entire repository from
oratonanospinner.nanospinnerhas a 17.5 TIMES smaller footprint [1], [2], and has just one dependency as opposed to 17.Note that
orais not removed from this repo's dependencies, as it remains a dependency ofinquirer. However, it's removed from package dependencies, resulting in faster install and smaller footprint for the end users.Test Plan
To be frank, I relied on TypeScript alone for this change and I don't know this project well enough to test it, especially the Android part.
nanospinneris almost a drop-in replacement fororaso I don't expect major issues though.Checklist
react-nativecheckout (instructions).