Skip to content

Conversation

kraenhansen
Copy link
Contributor

Summary:

See facebook/react-native#53563 for more context.

TLDR; Since jest and @types/jest are dependencies of the app and not react-native, it makes sense to move this into the app template.
This also allow libraries (not necessarily using jest) to use @react-native/typescript-config without having to install jest or re-declare types.

Changelog:

[GENERAL] [ADDED] - Add explicit use of jest types in tsconfig.json

Test Plan:

  1. Initialize the template npx @react-native-community/cli@latest init TestApp
  2. Patch the tsconfig.json
  3. Note how this doesn't affect the ability to use describe in source files.

@cortinico
Copy link
Member

@robhogan could you review this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants