Skip to content

Conversation

@saumier
Copy link
Contributor

@saumier saumier commented Oct 8, 2025

Updated spec and schema to add "id" as an explicit matchType option for reconciliation queries.

@saumier saumier linked an issue Oct 8, 2025 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for reconciliation-api-specs ready!

Name Link
🔨 Latest commit 1b58deb
🔍 Latest deploy log https://app.netlify.com/projects/reconciliation-api-specs/deploys/68e6ed96c9228500089b7fa9
😎 Deploy Preview https://deploy-preview-195--reconciliation-api-specs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added two minor suggestions for consistent punctuation.

<dl>
<dt><code>matchType</code></dt>
<dd>{{String}} (required) either <code>name</code> or <code>property</code>, depending on whether the condition relates to entity names or their properties.</dd>
<dd>{{String}} (required) either <code>name</code> or <code>id</code> or <code>property</code>, depending on whether the condition relates to entity names, entity ids or their properties.</dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<dd>{{String}} (required) either <code>name</code> or <code>id</code> or <code>property</code>, depending on whether the condition relates to entity names, entity ids or their properties.</dd>
<dd>{{String}} (required) either <code>name</code> or <code>id</code> or <code>property</code>, depending on whether the condition relates to entity names, entity ids, or their properties.</dd>

"matchType": {
"type": "string",
"description": "A string to indicate whether to match the supplied value to entity names or property values",
"description": "A string to indicate whether to match the supplied value to entity names, entity ids or property values",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "A string to indicate whether to match the supplied value to entity names, entity ids or property values",
"description": "A string to indicate whether to match the supplied value to entity names, entity ids, or property values",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add explicit matchType 'id'

4 participants