-
Couldn't load subscription status.
- Fork 10
Updated spec and schema to add "id" matchType #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…or reconciliation queries.
✅ Deploy Preview for reconciliation-api-specs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added two minor suggestions for consistent punctuation.
| <dl> | ||
| <dt><code>matchType</code></dt> | ||
| <dd>{{String}} (required) either <code>name</code> or <code>property</code>, depending on whether the condition relates to entity names or their properties.</dd> | ||
| <dd>{{String}} (required) either <code>name</code> or <code>id</code> or <code>property</code>, depending on whether the condition relates to entity names, entity ids or their properties.</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <dd>{{String}} (required) either <code>name</code> or <code>id</code> or <code>property</code>, depending on whether the condition relates to entity names, entity ids or their properties.</dd> | |
| <dd>{{String}} (required) either <code>name</code> or <code>id</code> or <code>property</code>, depending on whether the condition relates to entity names, entity ids, or their properties.</dd> |
| "matchType": { | ||
| "type": "string", | ||
| "description": "A string to indicate whether to match the supplied value to entity names or property values", | ||
| "description": "A string to indicate whether to match the supplied value to entity names, entity ids or property values", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "description": "A string to indicate whether to match the supplied value to entity names, entity ids or property values", | |
| "description": "A string to indicate whether to match the supplied value to entity names, entity ids, or property values", |
Updated spec and schema to add "id" as an explicit matchType option for reconciliation queries.