chore(KFLUXSPRT-5265): Add deployment & secret to konflux-support-ops base #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kousalya1998
requested review from
gbenhaim,
hugares and
enkeefe00
as code owners
hugares
reviewed
Sep 26, 2025
| @@ -0,0 +1,18 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
we should not add secret using Argo, you need to store the secret in vault under stonesoup/[staging/produciton]/[your team folder] and extract the value here using an ExternalSecret
There was a problem hiding this comment.
I removed the secret file for now. I will add them to Vault
|
@Kousalya1998 Also please make sure there are no kube-linter issues, the check is failing because you are adding some. |
Kousalya1998
force-pushed
the
KFLUXSPRT-5625
branch
from
0ed4538 to
69c3947
Compare
Kousalya1998
force-pushed
the
KFLUXSPRT-5625
branch
from
69c3947 to
5ffe66b
Compare
enkeefe00
reviewed
Sep 26, 2025
| spec: | ||
| containers: | ||
| - name: support-ops | ||
| image: quay.io/klakshma/konflux-support-ops:v1.0.0 |
There was a problem hiding this comment.
Are you meant to be using a personal image for the deployment here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deployment.yaml
Add secret.yaml
Update kustomization.yaml