[DO NOT MERGE] [RHTAP-4916-config] Add Azure to CI configuration #1242
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsmid1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughUpdated the pipeline task Git source and revision in the tssc-cli-e2e pipeline and appended a new tssc configuration entry to the integration test plan JSON. No control flow or pipeline logic was changed. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
integration-tests/pipelines/tssc-cli-e2e.yaml (1)
171-176: Parameterize repo URL and revision for easier toggling in test vs. prod.Make these values pipeline params to avoid future code diffs and accidental merges with test settings.
Within this block:
- - name: url - value: https://github.com/jsmid1/tssc-test.git + - name: url + value: $(params.tssc-test-repo-url) - name: revision - value: RHTAP-4916-config + value: $(params.tssc-test-revision)Add params near other pipeline params:
- name: tssc-test-repo-url type: string default: https://github.com/redhat-appstudio/tssc-test.git - name: tssc-test-revision type: string default: main
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
integration-tests/pipelines/tssc-cli-e2e.yaml(1 hunks)
🔇 Additional comments (3)
integration-tests/pipelines/tssc-cli-e2e.yaml (3)
165-168: KeepingonError: continuehere is fine for non‑blocking UI tests.This protects cluster deprovision and artifact collection even if UI tests fail.
171-176: Resolved — target file exists at the specified ref (HTTP 200)
HTTP 200 confirmed for the raw URL; no CI change required.
149-154: Confirm intentional version skew between steps.Resolved task specs differ: redhat-appstudio/tssc-test@main -> integration-tests/tasks/tssc-e2e.yaml (10,063 bytes, metadata.name: tssc-e2e) vs jsmid1/tssc-test@RHTAP-4916-config -> integration-tests/tasks/tssc-ui.yaml (6,124 bytes, metadata.name: tssc-ui). Confirm this split is intentional to avoid task/API drift.
File: integration-tests/pipelines/tssc-cli-e2e.yaml — lines 149–154 and 171–176.
| - name: url | ||
| value: https://github.com/redhat-appstudio/tssc-test.git | ||
| value: https://github.com/jsmid1/tssc-test.git | ||
| - name: revision | ||
| value: main | ||
| value: RHTAP-4916-config | ||
| - name: pathInRepo | ||
| value: integration-tests/tasks/tssc-ui.yaml |
There was a problem hiding this comment.
Pin to a commit SHA and avoid personal fork for pipeline supply‑chain safety.
Pointing Tekton resolver to a mutable branch on a personal fork is risky. Pin to an immutable commit SHA (and, ideally, keep source under the trusted org) to ensure reproducible, auditable runs.
Apply after replacing <COMMIT_SHA> with the exact commit on RHTAP-4916-config:
- - name: url
- value: https://github.com/jsmid1/tssc-test.git
+ - name: url
+ value: https://github.com/jsmid1/tssc-test.git
- name: revision
- value: RHTAP-4916-config
+ value: <COMMIT_SHA>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: url | |
| value: https://github.com/redhat-appstudio/tssc-test.git | |
| value: https://github.com/jsmid1/tssc-test.git | |
| - name: revision | |
| value: main | |
| value: RHTAP-4916-config | |
| - name: pathInRepo | |
| value: integration-tests/tasks/tssc-ui.yaml | |
| - name: url | |
| value: https://github.com/jsmid1/tssc-test.git | |
| - name: revision | |
| value: <COMMIT_SHA> | |
| - name: pathInRepo | |
| value: integration-tests/tasks/tssc-ui.yaml |
🤖 Prompt for AI Agents
In integration-tests/pipelines/tssc-cli-e2e.yaml around lines 171 to 176 the
Tekton resolver points at a mutable branch on a personal fork; replace the
repository URL with the trusted org repo (not a personal fork) and set revision
to the exact commit SHA instead of the branch name (replace <COMMIT_SHA> with
the actual SHA for RHTAP-4916-config); ensure pathInRepo remains correct and
verify the SHA exists in the chosen trusted repo so the pipeline uses an
immutable, auditable source.
jsmid1
force-pushed
the
RHTAP-4916-config
branch
from
5063705 to
670f265
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
integration-tests/config/testplan.json (2)
28-32: Fix indentation to match surrounding JSON style.Align with the existing 6–8 space indentation for consistency.
- { - "git": "github", - "ci": "azure", - "registry": "quay", - "tpa": "remote", - "acs": "remote" + { + "git": "github", + "ci": "azure", + "registry": "quay", + "tpa": "remote", + "acs": "remote" }
26-33: Confirm test coverage for the new Azure/remote variant.The tests array is unchanged; ensure there’s at least one test path exercising this new tssc combo or that it’s intentionally excluded for this DO NOT MERGE run.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
integration-tests/config/testplan.json(1 hunks)integration-tests/pipelines/tssc-cli-e2e.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- integration-tests/pipelines/tssc-cli-e2e.yaml
🔇 Additional comments (1)
integration-tests/config/testplan.json (1)
26-33: Schema compatibility: verify that "ci": "azure" is supported by consumersIf code validates/branches on CI values, ensure "azure" is included in the accepted enum (e.g., tekton, githubactions, gitlabci); otherwise this entry may be ignored or fail validation.
Location: integration-tests/config/testplan.json (lines 26–33 — snippet unchanged)
}, { "git": "github", "ci": "azure", "registry": "quay", "tpa": "remote", "acs": "remote" }
|
/retest |
jsmid1
force-pushed
the
RHTAP-4916-config
branch
from
670f265 to
c0bb94e
Compare
jsmid1
changed the title
jsmid1
force-pushed
the
RHTAP-4916-config
branch
from
c0bb94e to
f6a7d1d
Compare
jkopriva
force-pushed
the
RHTAP-4916-config
branch
from
f6a7d1d to
6c3b516
Compare
|
|
@jsmid1: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.17-rf76bTest results analysis<not enabled> OCI Artifact Browser URL<not enabled> |
2 participants
This PR is for testing purposes.
Summary by CodeRabbit