Jetbrains Gateway cannot connect after 3.5h IDLE period #148
Conversation
vrubezhny
requested review from
adietish and
azatsarynnyy
and removed request for
azatsarynnyy
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 4 25 +21
Lines 26 1008 +982
Branches 0 157 +157
======================================
- Misses 26 1008 +982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vrubezhny
force-pushed
the
fix-cannot-connect-when-idle
branch
2 times, most recently
from
86b4d42 to
7dd1828
Compare
There was a problem hiding this comment.
I run the plugin from vrubezhny:fix-cannot-connect-when-idle,
and I noticed the UI differs from what is shows on the screenscasts
@vrubezhny do you think I missed some steps?
There was a problem hiding this comment.
@adietish could you please verify if the PR fixes the original issue you reported
Fixes eclipse-che/che#23485 Signed-off-by: Victor Rubezhny <[email protected]>
adietish
force-pushed
the
fix-cannot-connect-when-idle
branch
from
7dd1828 to
58a72b8
Compare
| onDevWorkspaceStopped: () -> Unit, | ||
| onDisconnected: () -> Unit | ||
| ) { | ||
| try { |
There was a problem hiding this comment.
nitpicking: I'd create separate methods for all 3 closing operations (closeForwarder(), stopDevWorkspace(), invokeOnDisconnected) and call them here.
|
|
||
| val client = LinkedClientManager | ||
| .getInstance() | ||
| .startNewClient( | ||
| Lifetime.Eternal, | ||
| URI(remoteIdeServerStatus.joinLink), | ||
| URI(remoteIdeServerStatus.joinLink!!), | ||
| "", | ||
| onConnected, | ||
| false | ||
| ) | ||
|
|
||
| val forwarder = Pods(devSpacesContext.client).forward(remoteIdeServer.pod, 5990, 5990) |
There was a problem hiding this comment.
#forward can fail, too ex. if local port is already bound.
|
|
||
| val client = LinkedClientManager | ||
| .getInstance() | ||
| .startNewClient( | ||
| Lifetime.Eternal, | ||
| URI(remoteIdeServerStatus.joinLink), | ||
| URI(remoteIdeServerStatus.joinLink!!), |
There was a problem hiding this comment.
I saw situations where the joinLink was null. I believe that it would be better to check the joinLink for being non-empty and throw instead of asserting it to be non-null (!!)
When the DevSpaces WS isn't started or ready, this PR starts the WS and waits for its readiness before starting the Remote IDE Client:
cold-start_spedup.mp4
In some cases the Remote IDE Server cannot correctly process requests (status/stop) - usually when this happens we have no other option to recover, but the full DevSpaces Pod restart. so. with this PR, the User is asked to restart and if agreed, the DevSpaces Pod gets terminated and then restarted, which in its turn makes the Remote IDE server to correctly start:
remote-ide-not-responsive_spedup.mp4
Fixes eclipse-che/che#23485